Mike Deverell

Results 15 comments of Mike Deverell

I'd like to ask that this be revisited. I'm using chrome-launcher in a typescript project, but am getting errors because the d.ts files are not included. It should be a...

@samccone Yeah, that'll work. Another alternative could be renaming `chrome-launcher.ts` to `index.ts`, or (to not break backwards compatibility with people already implementing your solution) create a separate `index.ts` containing: ```...

Looks like this would actually be fixed via #39?

For what it's worth, there is an open PR at CSSOM here: NV/CSSOM#94 It's currently waiting on tests being written, which I'm hoping to do tonight.

This was fixed with NV/CSSOM#94 & NV/CSSOM#96, and available in CSSOM v0.3.3. It looks like `jsdom` is just looking for `>= 0.3.2 < 0.4.0`, so it should be available to...

@samdenty Thanks for opening a PR. Can you add tests to reproduce your issue? I don't doubt that it happens, but I have trouble figuring out when `getComputedStyle(el).height` would return...

I'll have to dig more into this. The `ResizeObserver` algorithm for [calculating box size](https://drafts.csswg.org/resize-observer/#calculate-box-size) has updated since my last update to this package, so we'll have to do another round...

#10 (TypeScript Rewrite) introduced some issues with calculating coverage due to the map files not making it all the way to the `dist` directory. We'll want to fix that first...

@samdenty Can you add tests to reproduce?