devin ivy

Results 170 comments of devin ivy

Great, thanks for the speedy feedback. > Test against windows I hear all of that πŸ‘ . I actually really underestimated the complexity of this task. I spent some time...

I agree that LRU would be a good way to do this! I just hope that implementing LRU doesn't require much space in loacalStorage. Perhaps LRU should be implemented per-page-load...

The way redux approaches this is having a terribly simple event-based subscription (`store.subscribe(cb)`) that can trivially be adapted to any observer library, etc.

I would personally support taking a PR for this feature request as described πŸ‘

hapi v19 shouldn't be tested against node v16β€” I think that's the cause of the issues. Not sure exactly why it's like that. There is one test that's failing on...

Bumping this and the PR #293 for any further discussion/review/thoughts.

In the case of no. 2, what error would be returned: would it be a `badImplementation()` with the passed non-error set as `data`? Would it respect the `statusCode` option?

This would be great πŸ‘ We might also look for compatibility with [bounce's error matching](https://hapi.dev/module/bounce/api?v=2.0.0#rethrowerr-types-options).

I can tell this was a major effortβ€” the contribution offer is appreciated. There's a lot to dig into and consider here, but I wanted to followup to let you...

In the code and tests, the module is fairly explicit about what it's trying to do when it sees a non-unauthorized error: https://github.com/hapijs/cookie/blob/fa728d73095278b34186797f3f42cf032eea8eca/test/index.js#L374-L414 That means that we'd need to treat...