devin ivy

I agree that it would be convenient to have concrete types for records embedded in responses like this. The issues we run into here are that a. technically users have...

Yeah `unknown` can be thought of as the type `Record` in typescript: it's guaranteed to be an object (i.e. not an array or primitive).

Would you mind adding tests to help illustrate what cases this covers? Also, is it possible that we can do this without an additional dependency using the WHATWG `URL` interface?...

It looks like there's some consensus here and this is good to close. If that doesn't seem right just say the word and we can reopen.

@bnewbold the issue was pretty buried in the output there— it was actually just a small thing in `packages/bsky/src/api/com/atproto/moderation/util.ts`. Should be all good now 👍

Read through these and all looked good— appreciate it!

We also just landed #1021, which should help. Anyone interested in doing a quick bench from `main` to see where we're at?

Closing this because we've made an order of magnitude improvement with everyone's help, and I don't think there are additional actions to take at the moment. But we'll be keeping...

Tested this out and it seems to work as advertised, nice 👍 TBH would be nice to get signoff from Paul, more so on the behavior than the implementation.

Closing as stale, we can reopen if we get some new info that points to a possible issue.