Jason Miller

Results 1188 comments of Jason Miller
trafficstars

This is awesome @sskoopa! Only thought I had was maybe use `props.base` directly and skip persisting it into `state.baseUrl`. Think that'd work?

Ack! Sorry, I hadn't meant to mutate `this.props` heh. I figured something like: ```js class Router extends Component { constructor(props, context) { super(props); let base = props.base || ''; if...

Could just leave it as `this.base` - the reason to skip passing it into state was to avoid a re-render.

this is high on my todo list, we're using workarounds right now and it's ugly.

Nah it's more just me wrapping my head around things. I just need to play around with the nesting - you already have good test coverage here, that's what I...

Yes - sorry for dropping this on the floor, we're super keen to get this merged too since our apps are using a workaround right now.

Awesome, thanks a bunch! Hopefully we can merge this, right now we are hacking around it haha.

I tried and failed to resolve conflicts, didn't want to botch it.

If anyone wants to take a stab at resolving the conflicts that'd help. We all want it merged :)