Jason Miller

Results 1186 comments of Jason Miller
trafficstars

Just some thorough battle testing (or more unit tests?)

Note to self: tests need to be updated to only use components as children, and to test that elements as children do not receive router props.

@vimtor this issue only happens when using a version of `preact-router` that is out of date - just updating to version `3` fixes it.

Can you re-test this with the recently-released preact-router version 4?

The initial page load issue _may_ be addressed via #416. The activeClassName and Match usage should be fixed by #416 though.

Hmm. That should have been fixed by c4ee6c8. Must have missed a case.

That's odd - `route()` is the same mechanics we use for wiring up links... any chance you found a solution to this issue?

I believe this needs to steal from the other relative links PR to enable `route('./foo')`

Might have odd interplay with the match ordering from #136

Maybe we could allow a function or regex in addition to a pattern string? Could just let the regex matches be passed down as numeric properties.