langchain icon indicating copy to clipboard operation
langchain copied to clipboard

Adding mlflow tests

Open akshaya-a opened this issue 2 years ago • 1 comments

@agola11 + @hwchase17 + @dev2049 thanks for the review and pushing the PR over the finish line!

I'd like to add a few more tests in a follow up - are you willing to add mlflow + azureml-mlflow packages as test dependencies or should we explore some other options?

Originally posted by @akshaya-a in https://github.com/hwchase17/langchain/issues/4150#issuecomment-1540983848

akshaya-a avatar May 11 '23 16:05 akshaya-a

test dependencies should be ok!

dev2049 avatar May 11 '23 17:05 dev2049

Hi, @akshaya-a! I'm Dosu, and I'm here to help the LangChain team manage their backlog. I wanted to let you know that we are marking this issue as stale.

From what I understand, you were requesting to add mlflow tests and were asking for input on whether to add mlflow + azureml-mlflow packages as test dependencies or explore other options. It seems that dev2049 suggested that test dependencies should be okay, and you agreed with a thumbs up reaction.

Before we close this issue, we wanted to check with you if it is still relevant to the latest version of the LangChain repository. If it is, please let us know by commenting on the issue. Otherwise, feel free to close the issue yourself, or it will be automatically closed in 7 days.

Thank you for your contribution!

dosubot[bot] avatar Sep 05 '23 16:09 dosubot[bot]

Sorry for not following up in this thread, for anyone that ends up here later, there are tests being added for the most important part (serialization) here, so decided not to duplicate efforts in this repo for now while things are moving quickly: https://github.com/mlflow/mlflow/tree/master/tests/langchain

akshaya-a avatar Sep 12 '23 16:09 akshaya-a