golang-set

golang-set copied to clipboard

add Append() method for adding multiple elements to set

6

This PR implements `Append` method and resolves #92 . Test results: ```shell $ go test -cover PASS coverage: 94.8% of statements ok github.com/deckarep/golang-set/v2 0.767s ```

SignorMercurio

like java `equals` method of Object class

Crisyix

Panics with trivial test cases

1

The internals of this library use a downcast of the Set interface to `*threadSafeSet` and `*threadUnsafeSet` everywhere. I'm unclear why an interface is used in this package when the logic...

natefinch

adding method to create set from keys of map of type comparable

4

I added `github.com/google/gofuzz` to do fuzzy testing. If you are against it, then I will remove the dependency and hardcode the test input, but that makes the testing less resilient....

jay-babu

Creating Set from passed in Map

6

Hello, I was wondering what your thoughts were on adding a func to create a Set from Map `mapset.NewSetFromMapKey[T](map[T]any)` `mapset.NewSetFromMapValue[T](map[any]T)` I find myself doing this often. Thought others might as...

jay-babu

What about adding a `set.Append(vals...T)` method to add multiple values to an existing set?

1

We've got `NewSet(vals...T)` for creating a set from multiple values. But today I found myself wanting to add a slice of objects to an existing set... today I have to...

jeffwidman

Suggestion: change the package name and the project name the same one

2

> It's helpful if everyone using the package can use the same name to refer to its contents, which implies that the package name should be good: short, concise, evocative....

bom-d-van

Set map capacity for some functions can improve performance

5

Recently I use golang-set to help optimize a DFA generator. And I noticed DFA‘s compile time increased a lot. New code:  Before:  After:  pprof:  `golang-set` based...

fy0

Feature Request: TOML Serialization

2

It would be really valuable if this set type implemented the [BurntSushi `TextUnmarshaler` interface](https://github.com/BurntSushi/toml#using-the-encodingtextunmarshaler-interface), so it can be used with that library without needing to wrap the set (or fork...

ameyer-pivotal

deckarep