golang-set icon indicating copy to clipboard operation
golang-set copied to clipboard

adding method to create set from keys of map of type comparable

Open jay-babu opened this issue 3 years ago • 4 comments

I added github.com/google/gofuzz to do fuzzy testing. If you are against it, then I will remove the dependency and hardcode the test input, but that makes the testing less resilient.

I decided against adding a method to create a Set from values of Map. Happy to do so if you want

jay-babu avatar Apr 09 '22 03:04 jay-babu

https://github.com/deckarep/golang-set/issues/90

jay-babu avatar Apr 09 '22 03:04 jay-babu

So, I am going to lean towards not relying on the fuzz library because we’re dealing with types purely designed within the Go language.

I would definitely be in support of GoFuzz if this were something along the lines of a protocol where fuzzing is definitely warranted to ensure proper parsing of inputs.

deckarep avatar Apr 09 '22 23:04 deckarep

@deckarep should be good to go

jay-babu avatar Apr 22 '22 21:04 jay-babu

@deckarep any update?

jay-babu avatar Jun 25 '22 02:06 jay-babu

@deckarep gentle reminder

jay-babu avatar Mar 03 '23 05:03 jay-babu