Dongbo Wang

Results 460 comments of Dongbo Wang

@deeplee can you be more specific about what command/script you ran that triggered the crash?

I don't fully understand the gains of this work, especially given that it's a breaking change. > Breaking change because System.Text.Json have many minor (by design) breaking changes compared with...

> do we want to rid of Newtonsoft.Json in the milestone? I think this largely depends on whether we can retain the same behavior as of today. If breaking changes...

@PowerShell/powershell-committee Please review to decide whether this PR is desired. Please see the comments starting from https://github.com/PowerShell/PowerShell/pull/14411#issuecomment-1258755659 for reference and context.

@MartinGC94 Sorry for the delay on responding. The Engine WG discussed this PR briefly in our last meeting, and we agreed that this would be a nice improvement to have....

Reopen this issue because the fix (#17856) causes a regression reported in #20739, and thus it will be reverted by #21368. Will let the engine WG review this issue and...

@MartinGC94 Sorry for taking so long to review. Can you please resolve the conflicts for this PR?

@MartinGC94 Thanks for the contribution and I appreciate your patience.

@SeeminglyScience Most of my comments above are not replied. Can you please reply to my comments, so as to help me understand what changes were made? Thanks!

> I notice this PR has 5 reviewers assigned to it. Does every single reviewer need to go over this PR? A reviewer is picked by the author (or the...