Dongbo Wang

Results 460 comments of Dongbo Wang

I submitted two PRs (WIP) with different designs for the List support in PowerShell: 1. #5762 -- Support `@[]`, similar to `@()` 2. #5761 -- Support `ListLiteralExpression '[]'`, similar to...

@markekraus It attempts to always create `List`, like `@()` ways create an `object[]`.

@lzybkr proposed to use new token pairs instead of `@[]` to represent a `ListExpression` in https://github.com/PowerShell/PowerShell/pull/5762#issuecomment-354512131: > You could consider 2 character tokens. > For example, F# uses this syntax...

@mklement0 IMHO, there would be 3 problems if we simply change the comma operator `','` to return a list: 1. The AST type name `ArrayLiteralAst` would be inconsistent, but changing...

`'%(1)'` is parsed into a `CommandAst` today, where `'%'` is the command name (foreach-object), and the argument is `(1)`. `'&(1)'` is parsed into a `CommandAst` today, where `'&'` is the...

> The alternative is to simply make @() always return a list. I talked to @jpsnover about this today and he also brought up changing the semantic of `@()` to...

@PowerShell/powershell-committee Need the committee to review whether we want to make changes to the `PSCompatibleVersions` key of `$PSVersionTable`.

Good catch @xtqqczze! @iSazonov Can you remove `src\System.Management.Automation\engine\parser\GlobalAssemblyCache.cs` in this PR as well?

The support in loading GAC assemblies is in `PowerShellAssemblyLoadContext`, not related to these 2 files.

@SteveL-MSFT Please take another look when you have time. All to-dos are done (please see the to-do list in the PR description). I will start adding the `command-not-found` feedback provider...