Davin McCall

Results 144 comments of Davin McCall

> I think I phrased that badly earlier, I'll rephrase it a little here now. Systemd makes use of SELinux a lot inside it being quite SELinux aware so it...

Could you remove the "Draft:" status if it's ready? I'll get to it when I can. A couple of things I noticed when looking quickly now: - could you add...

From ~CONTRIBUTING~ PR-PROCESS: ``` See CONTRIBUTING for details. In general new features (and their design) should be agreed upon *before* a PR is opened. ``` Please respect this in the...

``` # Test if the compiler accepts an argument (for compilation only); if so add it to named variable. # Note: this function will return failure if the flag is...

> @davmac314 I want to rebase from master branch to my branch for fixing merge conflict with [5a554d8](https://github.com/davmac314/dinit/commit/5a554d8bfce1f5ee280a0f8e8aefe85b8fd1ff69). Can I proceed? Yes, you can re-base in this instance. > (Do...

> From a technical perspective, there is an issue with string escaping. It doesn't look like you've really considered this at all. What does pkg-config do about shell metacharacters? Is...

> I must be missing something because I just reread my post and I still can't see where you got the idea that I said any such thing It's probably...

> Another idea can be execing shutdown-hook (I assume you mean from `dinit`, without first `fork()`ing) > @davmac314 WDYT? I don't like the hook having different arguments depending on the...

> "Fixes #issue" in the PR description was supposed to close this issue I disabled that functionality as it can result in incorrectly closed issues.