Davin McCall

Results 143 comments of Davin McCall

@mobin-2008 review was requested but you are still pushing changes. What's the deal? Is it ready for review or not?

I see I was wrong, it doesn't mean that it always returns 0. But returning `status` is also wrong. It should instead return a value (v) so that `WEXITSTATUS(v)` is...

> I squashed commits in `pr-338` branch and it's ready for review. You need to push the changes to your own branch for them to show up in the PR.

> Can you merge it manually from that branch? I would like to look over it beforehand, can you please push the changes to your branch

@mobin-2008 No, just push the commits to your PR branch please. I don't want to lose the review history either. This should be very easy to do.

> how do you escape a value for use in a makefile and in shell commands? Thinking further, the values supplied by the user (commands, command arguments) should be escaped...

> The result was correct, The my compiler was used not my with compiler argument in both configure and Makefiles. That's _not_ correct. It should be the opposite in both....

Also: > About the single value variables such as $CXX the fix I think would be quoting value when using it and putting it in mconfig You can never turn...

> But about multi value variables such as $CXXFLAGS we can't just quote value because it contains more than just one argument. I'm thinking about how to fix this. You...

I remember now that this is documented in BUILD_MESON: ``` 1. Sanitizers cannot be enabled only for tests, as they are by default in a Make-based build. ``` This was...