David Stosik comments

Results 66 comments of


                                            David Stosik

trafficstars

Fix hanging test due to interlocking(?)

@matthewd Thank you for the review! I checked `IO.pipe`, and indeed, it also has a buffer size limit, although way bigger than `PTY`: it's 64kB, which feels a lot more...

Support spaces in git repository path

cc @djmb

SSHKit does not escape command arguments, resulting in failure to clone a path with spaces

I just found this 8-year-old issue: [Issue: Trusted strings, shell escaping and backwards compatibility](https://github.com/capistrano/sshkit/issues/333). Unfortunately it seems to have rapidly lost any traction...

SSHKit does not escape command arguments, resulting in failure to clone a path with spaces

@MiroslavCsonka It's good to know that I'm not alone! Feel free to give a try to my fork by changing your Gemfile: ```rb gem "kamal", ">= 2.1.0", require: false, github:...

SSHKit does not escape command arguments, resulting in failure to clone a path with spaces

Will do! 👍🏻 Update: done! https://github.com/basecamp/kamal/pull/1066

SSHKit does not escape command arguments, resulting in failure to clone a path with spaces

@MiroslavCsonka Thanks for the report. Have you tried updating with `bundle update kamal`? I added more changes to my branch, so maybe I fixed that problem. If not, can you...