David Stosik

Results 66 comments of David Stosik
trafficstars

@kamipo Thank you for the added context! MySQL also supports "[per-session time zones](https://dev.mysql.com/doc/refman/8.4/en/time-zone-support.html#:~:text=Per%2Dsession%20time%20zones.)": ```sql SET time_zone = timezone; # timezone can be: # - SYSTEM (we don't want that) #...

@kamipo Would a fix like this below be preferable to what I previously had in [my PR](https://github.com/rails/rails/pull/53251)? ```diff diff --git c/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb i/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb index 2219d17b5d..53642641fc 100644 --- c/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb +++ i/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb @@...

> Feels like overreaching (setting the DB to something other than UTC) If I'm telling Rails "my MySQL is in local timezone", it doesn't feel overreaching that Rails would tell...

> I was under the impression that buildkite/ci was using a tty and therefor these tests were running. @yahonda can probably verify that. No you're right. I made a guess...

@zzak I just rebooted my laptop to be sure. Haven't got any Rails app running. The test still hangs. (macOS Sequoia, Ruby 3.3.5) While the test is hanging, I can...

Yep, seems to be a macOS issue, since I managed to get it to work on Linux too.

Thanks @djmb! I added this to the beginning of the hanging test: ```rb Signal.trap "SIGPROF" do Thread.list.each do |thread| puts "🌊" * 10 puts thread.name puts thread.backtrace puts end end...

@zzak I tried adding `sleep 5` after `assert_output("Listening on", primary)`, before `Net::HTTP.new`, but the test is still hanging. I'm still not pretending I understand whatever's happening with `PTY`, but for...

I wrote a lot more than what's below, but now I've identified the issue more clearly, what's next should suffice. If you want to see the process that got me...

We can generalize if/when we find other hanging tests later. 👍🏻