David Chisnall

Results 406 comments of David Chisnall

Snmalloc also does the latter, and it's much easier for new contributors: if CI fails in the formatting step, they're told 'run ninja clang-format in your build directory and commit...

It doesn't help to verify most of these things early because they can be modified by the time that they are used. We can verify the config_data and config_len according...

The host doesn't need to modify the descriptors at all, but it does need to read them and SGX doesn't have a mechanism for read-only sharing and the trust model...

I don't understand the question in the context of the virtio spec. Descriptors need to be written in the descriptor table and the pointer to them needs to be in...

The descriptors point to memory in the region managed by the SWIOTLB. This is allocated in different-sized chunks depending on the request being sent. Preallocating the descriptors would require significant...

All LKL code is inside the enclave, but I don't believe we're using the virio code in lkl/tools. @prp?

@bodzhang, I already pointed you at the code [above](https://github.com/lsds/sgx-lkl/issues/745#issuecomment-672041884).

The shadow routines are used for the memory mapped control registers. This includes the location that the driver writes to when it notifies the host that it has written entries...

@bodzhang, I believe this is correct. See src/lkl/virtio.c for the places where the enclave can read / write these fields. All accesse to this from LKL go via that interface....

@Francis-Liu, please can you drive this?