David Chisnall

@SeanTAllen, this looks as if it’s related to the signal delivery. I suspect there may be something in how the syscall handler checks for signals that is wrong here.

I believe the `write` call should return `EINTR`. Because signals are not being delivered to the wrong Linux task (#644), we are not setting substituting `EINTR` for the syscall return...

What is the bug here? Are these incorrect values? With a minimal disk image, these are the values that I would expect. Does the LTP test runner need an image...

What is the invalid address? Is it inside the enclave? Until we are using LKL’s mmap, we have a very conservative response to access ok and will allow any access...

Okay, looking at the code, I understand this a bit better: - The test allocates a page with `PROT_NONE` - The writev call is called with a pointer to this...

@mikbras, we need the cryptsetup removal in here before I do this because that will impact whether we need to keep something equivalent to `lkl_run_in_kernel_stack`. We can't actually use that,...

[ Duplicating our private discussion here ] We need to address the layering here before it can be merged. We should not be introducing new code into `src/enclave` that has...

I think everything in src should be formatted with the clang-format thing. It's really annoying trying to review diffs where people have mixed formatting changes in with real changes and...

If we're going to enable this in CI (and I recommend that we do), please also add a build-system target that runs the same command that CI runs to check.

Does the pre-commit hook fix the issue? If so, I'm happy. If not, if contributors get an error trying to commit and the instructions are any more complex than 'run...