David Barsky

Results 242 comments of David Barsky

> And pardon my ignorance but I thought that RustRover uses IntellijRust or is it now possible to use both of them? Not without some active work: while it is...

We've got an issue (https://github.com/rust-lang/rust-analyzer/issues/18948) that covers some stuff that we'd like from the new VFS, but one of the big items is flattening the VFS and having more of...

If you're using `tracing_subscriber`, set [`fmt::Layer::with_span_events`](https://docs.rs/tracing-subscriber/0.2.9/tracing_subscriber/fmt/struct.Layer.html#method.with_span_events) to [`FmtSpan::FULL`](https://docs.rs/tracing-subscriber/0.2.9/tracing_subscriber/fmt/format/struct.FmtSpan.html). This will cause `tracing_subscriber` to print out the the span's busy time (the total time for which it was entered) and idle...

> What do you mean? Is measuring time not recommended because it is expensive? My bad! No, please measure the elapsed time. I should've said that tracing is very conservative...

> Is it possible to Instrument async functions? The `fmt.rs` shave function is not async function. Yup! Take a look at this section: https://github.com/tokio-rs/tracing#in-asynchronous-code. In short, you've got two options:...

I'll make a PR for master; I just need it on v0.1.x to unblock a thing.

> I'm quite confused. What is the point of those benchmarks? If we want to test incrementality, we should check salsa's logs. But it looks like you want to measure...

> I think the source snippets here are likely way too small/simple to give us any interesting numbers Didn't see this, sorry! At which size do you think the snippet...

> But I don't fully understand the concept/advantages of ra's automatic project discovery. Would you mind explaining? In what ways will it improve the Rust Bazel IDE experience? I think...

> Does this mean it could generate based on the open buffers / crate you're currently in ? Yes, but you can still can still generate a `rust-project.json` for the...