David Barsky

Results 244 comments of David Barsky

_Big_ plus one on this. The example on [“Returning Futures”](https://tokio.rs/docs/going-deeper/returning/) under the title “Custom types” would be great if it could be fleshed out. As a bit of low-hanging fruit,...

An example I'd like to write: ```rust use hyper::{Client, StatusCode}; struct MyFuture { inner: Receiver, } fn foo() -> MyFuture { let (sender, receiver) = oneshot::channel(); let client = Client::new();...

@carllerche Good point. In this case, should I use oneshot's [spawn](https://docs.rs/futures/0.1/futures/sync/oneshot/fn.spawn.html) or Tokio's [spawn](https://docs.rs/tokio/0.1/tokio/executor/fn.spawn.html)?

Hmm, I'm seeing `Spawn Error { is_shutdown: true }` errors. To avoid wasting your time, can you point me to an example that implements a future over `oneshot`?

> The problem is most likely that you are calling foo() from off the runtime. You probably want to do: Hmm, tried that, and the issues persisted. I'll try to...

Yeah, the answer is to use Valuable. I'll close this issue then.

@mzabaluev I think we'll end up switching to `tracing` instead for logging purposes.

Hi folks: sorry the delay in responding. I'll try to go comment-by-comment. ## Required Changes in tracing Cijo: > 1. Introduction of [Span Kind](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/api.md#spankind), an enum with 5 variants Server,Client,Producer,Consumer,Internal....

> > Cijo, Lalit, and Zhongyang explained it better than I could in their respective comments (and with greater tact and care—sorry, I haven't had the time to edit this...

I mentioned this in other contexts, but I don't think that we, as the `tracing` project, will do this. I understand why this issue/discussion needs to happen, however. > I...