Anton Fedorov

Results 11 comments of Anton Fedorov
trafficstars

looks like share(0) missed in ha_pinba constructor, and if(!share)free_share(share) should be in ::close(). I'll test that tomorrow.

I can't reproduce it stable -- i just have system in production, and script that every 5 minutes doing SELECT from aggregate tables, and TRUNCATE after. Already twice mysql server...

I need to get exact values for 5min -- so i need read & clear, so averages will be correct

thanks, i'll try that, but that doesn't fix possibility of mysql server crash, caused by freeing non-initialized share pointer

that line are caused crash, but note that free_share are inlined, so crash in free_share() https://github.com/tony2001/pinba_engine/blob/master/src/ha_pinba.cc#L1650 here is constructor: https://github.com/tony2001/pinba_engine/blob/master/src/ha_pinba.cc#L1616 and it doesn't nullify share pointer

Yes, it can return NULL.... But free_share doesn't check is incoming pointer null.

Hhhmmm... Yes, it's indeed WebAPI only (doesn't make much sense to me). But the value is only updated by app syncing, so it could be updated on phone side and...

Not sure I follow. What you trying to do? I don't know flowplayer. Could you describe issue better?

I would explect you just have flash not enabled. Please note, it requires flash support, which is going far-far away and soon will no longer work. I'm not sure is...

Yes, known problem. Currently file fully buffers in RAM for rewind. It should be possible to limit maximum size to some amount of RAM by changing File() class to keep...