Danny Valente
Danny Valente
@umberto-sonnino The code that is in place currently does not work correctly in the case where there is a valid cached actor, because the method is an async method, and...
@luigi-rosso I think this looks good and I like the idea. This change doesn't fix the issue with the flare animation not resuming at the correct location, from where it...
@luigi-rosso We're seeing an exception being thrown in our app from the new flare code. ``` Unhandled Exception: NoSuchMethodError: The method 'inheritFromWidgetOfExactType' was called on null. Receiver: null Tried calling:...
@umberto-sonnino This sort of tripped me up, as we started seeing flashing in our app and it was because flares were suddenly getting pruned, so that when using them again...
Unfortunately no workaround @emilysmithson . The only thing is to not pre-cache, or only pre-cache ones that are critical. @umberto-sonnino any thoughts on my comments above?
[✓] Flutter (Channel dev, 1.18.0-11.0.pre, on Mac OS X 10.14.6 18G4032, locale en-US) • Flutter version 1.18.0-11.0.pre at /Users/danny.valente/Library/flutter/1.18.0-11.0.pre-dev • Framework revision 8568eda15b (3 days ago), 2020-05-05 16:10:41 -0700 •...
FYI @goderbauer
> I like this! I do think we'll need some more thorough tests that actually exercise the behavior of the log reader before I can approve this. This could be...
> > Thanks for the comment @bkonyi! Can you point me to where this test should live? I have not been able to find where the other commands from the...