Danish Prakash

Results 67 comments of Danish Prakash

@farcaller I would like to work on this issue. On the same note, are you specifying bare `except`s here or something totally different? I can see [this](https://github.com/danishprakash/kasane/blob/master/tests/feature/test_cli.py#L54-L54) which seems a...

Correct me if i'm wrong but you want no stacktraces to be printed but just a brief error messages relevant to the error, right?

sorry yet again for the multi-month delay, I have time now and will be looking into this actively. @haircommander before I raise a PR, I just wanted to run this...

> I can't point a finger at anything wrong with this, but I'm not sure if it's a good idea to do the copy of the symlink. You're right, but...

> then we need to make sure the symbolic link still points within the image. Are you suggesting we _move_ the target to the container and then create a symbolic...

Planning to add a test for this over at https://github.com/containers/podman/pull/18020 utilizing the `--follow-link` flag. I tried doing it here, but we don't plan to add the flag here and copier...

> Without changing the `info` value that's passed to `copierHandlerGetOne()`, the `Typeflag` in the header it outputs for the tar archive shouldn't be changed, so I'm not sure this produces...

Mind If I take a look at this?

Not yet, I'll take a look at it end of next week.

I can start looking at it now, is this still open?