Daniel Fainberg

Results 20 comments of Daniel Fainberg

@CefasR I agree. I also encountered this issue. It would be awesome, if someone patched this. For now, since I also ran into this problem using F-expressions, I used this...

I think this is essentially a duplicate of this: - #6 I agree that this is worthwhile, but I suggest closing this duplicate issue.

One quick look at the [source code](https://github.com/tiangolo/sqlmodel/blob/main/sqlmodel/engine/create.py#L45) shows that the custom `create_engine` function literally passes the `url` argument unchanged to the corresponding SQLAlchemy function. Please make a little effort, instead...

I cannot reproduce this error. Works fine for me. What version of SQLAlchemy is installed in the environment where you experienced this error? Or has this issue been resolved?

I created an answer for this with more detailed explanations and tests [**here**](https://stackoverflow.com/q/73420018/19770795), but this is the short version: ```python from typing import Optional from sqlmodel import Field, Relationship, SQLModel...

I can confirm. Here is a simplified version for testing (compatible with Python 3.7+): ```python from typing import List, Optional from sqlmodel import Field, SQLModel, create_engine, Session, Relationship class Foo(SQLModel,...

With all due respect, what does this question have to do with the **SQLModel** project? The docs make it very clear that this is a thin layer around the SQLAlchemy...

@BenediktAllendorf I absolutely agree. I don't even think the "bus factor" is the main issue here. That is just a hypothetical worst-case scenario. It's that after a certain point the...

First off, if you haven't already, I suggest reading [this section](https://sqlmodel.tiangolo.com/tutorial/fastapi/relationships/#dont-include-all-the-data) of the docs. It addresses the issue of infinite recursion (among other things) that can easily happen, if you...

Yes, I know what you mean. I've been thinking about this a lot recently. Maybe someone will figure out an intuitive design for this. Because I don't think the issue...