Daniel Xu
Daniel Xu
Thanks rht! I have addressed all the comments you have and it should be ready to merge.
Sorry for the delay. I have addressed the previous comments. Let me know if there is anything needs to be changed.
I am getting build fail. Is there any way to resolve this?
from what I know, PyIBL cannot be installed by using pip. Should I remove pyibl from the requirement file?
I fixed the test file. There are two tests not passed, and both of them indicate some issue in ipynb file. I suspect there are some issues in codespell and...
The error I got is like this. ` Error: ./examples/el_farol/el_farol/el_farol.ipynb:214: te ==> the, be, we, to Error: ./examples/el_farol/el_farol/el_farol.ipynb:214: te ==> the, be, we, to Error: ./examples/el_farol/el_farol/el_farol.ipynb:214: fO ==> of, for...
Thanks @rht! I changed it and the commit should be ready to go.
Yes. I think I used the code editor formatted it once. Should I change it back?
I used the lint-black to format el_farol.ipynb multiple times, but it still does not pass the test. Should I also exclude this for lint check ?
> I ran the CI. It looks like el_farol.ipynb is not properly Blacked yet. Make sure to use the latest version of Black locally. I am using the latest ones...