Daniel Shahaf

Note to self: audit for null argument elision.

The problem is here: https://github.com/danielshahaf/zsh-syntax-highlighting/blob/e9ab802593ebbfce5cf749b1854d2cc201b3aa68/highlighters/main/main-highlighter.zsh#L471-L482 $arg starts out as `'a'` (three characters), then `_zsh_highlight_main_highlighter_expand_path` dequotes, `_zsh_highlight_main__type` returns `alias`, and `_zsh_highlight_main__resolve_alias` doesn't find an alias named `'a'` (there's only an `a`...

Filed #479 which would affect the failure mode of this.

Remaining tasks: - [ ] Resolve all review comments - [ ] Update changelog - [ ] Fix trailing whitespace - [ ] `alias a=b; : 'a'` issue above, compare...

> Tests fail under zsh

Need precommand_options[nice]+=':' (Can't add it as a review comment) _edit_: Done in 06ae6f9

Left: - Address https://github.com/zsh-users/zsh-syntax-highlighting/pull/471#issuecomment-357249607 - alias lookup should only be done if it's either a global alias or at command word position - Address https://github.com/zsh-users/zsh-syntax-highlighting/pull/471#discussion_r161374006 - Resolve conflicts - Merge...

Triage: Incomplete; deferred ☹

> The idea is that we are still in the alias even when recursing into a nested list like a command substitution, so _highlight_list is the wrong place to local...

The C code enforces that an alias be ineligible for expansion whilst it's being expanded. It's easy to see that: `alias ls=ls` works.