Daniel Shahaf

Results 382 comments of Daniel Shahaf

To answer the deleted comment: z-sy-h uses $PATH via the `type` builtin to determine whether a command word should be highlighted in green or red. However, an expensive-to-access $PATH wouldn't...

> Try zsh 5.9. > I don't know that any maintainer has WSL, so, y'all may need to help investigate. Does it reproduce in zsh -f? Do make check and...

> Oh, I'm sorry. I provided the wrong info. I have `WARN_NESTED_VAR` option on. Edited the top post. The error message under master is in the second post. Given that...

> I can't reproduce the interactive bug, but this avoids warnings when the test harness sets WARN_NESTED_VAR > Thanks. Reviewing. > ``` > diff --git a/tests/test-highlighting.zsh b/tests/test-highlighting.zsh > index 8b564a8..cab2fe3...

> I'm not sure I'm happy with this strategy. Which is to say: why don't we just unset the option? Cross-referencing #758.

> [zsh-users/zsh@66152e8](https://github.com/zsh-users/zsh/commit/66152e8adad7b00935c0b5fbe0cf0a7df3c639c7) which I think was first included in 4.3.11. That's correct. If you follow the link on github you can click the ellipsis at the bottom of the log...

4.3.10 isn't supported: https://github.com/zsh-users/zsh-syntax-highlighting/blob/c7caf57ca805abd54f11f756fda6395dd4187f8a/README.md#L6 We used to require 4.3.17, but the threshold was lowered in #440. It seems that the threshold was lowered as far as tests still passed —...

@wasPrime The error message is a zsh syntax error message. It shouldn't be ending up anywhere near end users (it's at too low a layer of abstraction).

@phy1729 Maybe add a few words to preëmpt "What does 'are not supported' means?" questions? E.g., 'are not supported and [one-sentence description of the failure mode]'? Did you intend to...