Daniel Shahaf

FWIW, the zsh patch would be something like this: zsh patch: add `${(Z+\+)}` subflag ```diff diff --git a/Src/lex.c b/Src/lex.c index 1d86da94e..41008409a 100644 --- a/Src/lex.c +++ b/Src/lex.c @@ -714,7 +714,7 @@...

In `not ok 1 - [1,8] «noglob»`, why is the string between guillemets not of length 8?

First of all, this changeset fixes a bug whereby `!*` is highlighted as [globbing] rather than as [history-expansion]. Could you please write tests? The harness supports "expected failure" tests (printed...

> I'm using this plugin and > [this](https://github.com/zsh-users/zsh-history-substring-search) but > with latest update from master, substring search is not highlight all > of its portion. > > i.g: `for i...

The steps need an explicit `bindkey -e` since the default keymap isn't always `emacs`. I tried following your steps and I can reproduce _a_ problem, but not the same one...

By the way, zsh-history-substring-search overrides and reimplements some zsh-syntax-highlighting implementation details: https://github.com/zsh-users/zsh-history-substring-search/blob/4abed97b6e67eb5590b39bcd59080aa23192f25d/zsh-history-substring-search.zsh#L102-L195 That's not supported. It falls under "If it breaks, you get to keep both pieces.". zsh-history-substring-search needs to...

I don't know. You're welcome to bisect this, of course, but my previous comment in this issue stands: your configuration is unsupported. No one should be defining functions named _zsh_highlight*...

You can try to upgrade but manually disable the new codepath. (The old codepath is still there for compatibility with older versions of zsh.) Other than that, that's right, use...

Looks like someone PR'd this on the z-h-s-s side, https://github.com/zsh-users/zsh-history-substring-search/pull/135.

Thanks for the report. That actually sounds like either a PEBKAC (user didn't read post-install message) or a downstream bug (homebrew should make that message harder to overlook). Having said...