Curtis Summers
Curtis Summers
@kelvinqian00 This is excellent! I should have some time to review this in more detail in the next few days to get this merged in, but the first pass through...
@kelvinqian00 OK, I've had some time to look at this and I have few comments: I'm definitely seeing some test suite failures locally. To help see these failures in this...
@talatarazi1 Is this valid SQL? Please make sure your SQL runs correctly on your database first. After that, please provide more information with the HugSQL query that you are using,...
Yep, this is still broken. And, I can't get this to work with depstar either, so it's not just a leiningen issue. I'll have to switch back to macros. My...
I think this is a good idea for the simple case of parameters directly defined in the SQL. However, it's worth noting that HugSQL's support for Clojure Expressions and dynamic,...
Snippets don't merge parameters up into the calling query's parameter data. The reason for this is that a snippet generates an sqlvec (e.g., `["where id = ?" 2]`) and a...
So I'm considering the possibility that your request might be a fairly intuitive feature and would simplify some usage in the "small" where it's unlikely to create any confusing merges...
Yes, I think I've finally decided to implement this when I get some time to do so. The new feature will likely be called Fragments to stay away from part/partial...
This a good question and one that I considered when we added the `next.jdbc` adapter. A few thoughts around this issue: The trade-offs for any team/project encountering this switch would...
@weavejester This looks like a legitimate bug, and I'd be happy to accept a PR for this. It looks like `locking-take` and `locking-take-batch` should check for the existence of the...