Csiki

Results 34 comments of Csiki
trafficstars

Hi, I do something similar, my solution is in short: _webConf.skipApStartup(); addParameters(); const char* mode; if (tryLoadConfig) { if (!_webConf.loadConfig() && ...) return false; ... mode = "load config"; }...

> 1. Changing the advertise format will require third party software changes. I thought that your code generates the 19 bytes advertisements output and you only need to add the...

I see, all of them is 0x181a and it can rely only on the message length? Totally new format with a version byte as well? :D

Yes, it would need to save the voltage time to time. Or we would lose that date too? Does the statistics lost on battery change or at a firmware update?...

> I have installed batteries that have been stored for over 10 years. The initial voltage on them was 2.0V. After a day of work, it rose to 2.8V. Do...

In the capacitor case you don't get any meaningful battery percentage either. > Constantly transmitting the battery installation time is a waste of battery life. Elapsed time, but you are...

Thank you for the explanation. So the conclusion is that the battery percentage we get from LYWSD03MMC is not really good for anything and there is no point trying to...

The Required part can be fixed by https://github.com/zkSNACKs/WalletWasabi/pull/12989

Should I fix the CodeFactor's ["use char instead of string methods"](https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1865-ca1867) issue as well or separate pull request?