Ross Kinder

done. :)

PR would be welcome

Bumping to version 1.2.0 pulls in [this commit](https://github.com/russellhaering/goxmldsig/commit/84a66a77edd0984e2882223763c7daeae06169c6) which changes how comments are handled. This causes the `TestSPRejectsInjectedComment` test to fail with both comments enabled and disabled. That test was...

Thanks!!!

fixed in #478

Hi, @bneil -- Can you help me understand what the issue is that you are trying to address? Also, it might be appropriate to add a test?

Okay, so as far as I can tell, the errors that can occur here are all programming errors, there is no interaction with an OS or anything else that can...

I'm not sure why this wouldn't be handled by settings RequestedAttributes in the ACS?

Any chance for a PR?

Thanks for your patience. Yes, I think it is very much in scope, and a PR would be awesome. [btw, it's nice to hear from you and get your other...