saml icon indicating copy to clipboard operation
saml copied to clipboard

Respect redirectURI

Open bneil opened this issue 3 years ago • 3 comments

Ensures the redirectURI is respected even if RelayState was found in the acs parameters.

bneil avatar Apr 11 '22 21:04 bneil

@crewjam does this update meet expectation? I didn't see a contributing guide so I wasn't sure what if anything I needed to include other than a PR. I appreciate you taking the time and looking at this.

bneil avatar Apr 12 '22 16:04 bneil

Hi, @bneil -- Can you help me understand what the issue is that you are trying to address? Also, it might be appropriate to add a test?

crewjam avatar Jun 25 '22 13:06 crewjam

@crewjam I ran into this interesting issue where RelatyState was being set to the wrong url. So I tried using the override url to correct that, however without this PR the override url is overwritten by RelayState. This PR allows either use cases.

bneil avatar Jun 29 '22 22:06 bneil