Luke Kuzmish
Luke Kuzmish
> I would suggest renaming the class to reflect the main use case we have in mind... something like `FailIfExceptions(fn|exceptions)` or something like that. Went with `FailOnException`. Modified the constructor...
> If it's of any help, PHPUnit has assertions for exceptions: > > ``` > public function test_authorize(): void > { > $this->expectException(AuthorizationException::class); > $this->expectExceptionMessage('Some message'); > > Response::deny('Some message',...
> Doesn't this already solved with #50704 I did not know this existed. Thanks for mentioning it and nice work @nunomaduro! 1. This would be unavailable in tests which don't...
As I was working with this method today, I realized that this causes a failing test due to no assertions: ```php #[Test] public function throws_an_exception(): void { $myFunction = static...
@crynobone thanks for updating the target branch. Do you know if there's anything I can do to get this re-considered?
Is there a way to get the toml-test suite re-run officially? Would be nice to be able to monitor how much has already been chewed through. I realize I can...
This would be a welcome addition @GrahamCampbell 🙇
> @cosmastech, I have re-worked this one. There were a few problems with the original implementation. The main issue was when a value was resolved for a bad type, it...
> Hey @cosmastech - am I missing something in your example where you actually add it to the context? Holy cow, yeah I did forget that. But we could automatically...
> 1. I don't love that from a public API perspective, there is now public, hidden, and contextable data. What concerns do you have? Just the cognitive overhead? Do you...