Luke Kuzmish

Results 28 comments of Luke Kuzmish

That's a great call @timacdonald. My first thought was "should we make scopes Enumerable?" ```php Feature::for($models)->some()->active('feature1'); // or even Feature::for($models)->some->active('feature1'); ``` But looking at Enumerable interface, I imagine *most* of...

I just realized that this doesn't make any sense: ```php Feature::forSome(['taylor', 'tim'])->activate('foo'); // or deactivate ``` What do we do in that case? Throw an exception? Just activate them for...

I had a similar issue with a return type like this: ``` * @return DataCollection|ForbiddenResponse ```

Yes, it's in the controller method.

I think the issue here is caused by this: https://github.com/Seldaek/monolog/blob/32e515fdc02cdafbe4593e30a9350d486b125b67/src/Monolog/Formatter/LineFormatter.php#L241 If the first character in the log is `[` or `{` then it replaces those substrings with `"\n"`

> IMHO the only change I would suggest is matching the entire exception message rather than using stripos. According to github, the exception message hasn't changed for 9 years so...

> @willpower232 hi, It doesn't seem correct to check the message (even though it hasn't changed since a lot), how about the approach of checking if the app facade already...

> An `On` prefix makes me think, it's an event listener. `In` would sound more naturally to me. But then how would I make my super funny joke about `#[OnDasher]`,...

> Just my 2 cents: I would love if we can use RetryWhen instead. when is used everywhere else and sounds more like a sentence. We then could also implement...

> I was also thinking about the name, maybe `FailIf` would better convey the outcome? > > Of course, in that case, the condition should be reversed to: > >...