Connor Peet

Results 463 comments of Connor Peet

When renaming or making API changes, it is probably good to also update the built-in extension; useful to test the change and also prevent the possibility of a broken release...

The .d.ts does get used, but changes to contributions are not validated in that. > I was also wondering if there are tests we could add that would fail if...

Haven't heard back from the reporter, going to close this issue.

Fyi we are finalizing (in next week's 1.88 release) official support for test coverage, and using that avoids the issue https://github.com/microsoft/vscode/issues/123713

Any news on this? It would be great :) This was our solution to add the Squel query builder to Sequelize. Not super beautiful, but it works. ``` js var...

@janmeier you're correct in that it does not have baked-in support Sequelize models; it's mainly built for times where you're doing complex manipulation whose results, if any, would not fit...

Note to the people who use Squel in that way ( @joshrickert ) be **very aware** that toString() does not property escape supposedly parameterized values. This code snippet can be...

Probably duplicates https://github.com/wix/import-cost/issues/272

Probably duplicates https://github.com/wix/import-cost/issues/272

I hit this again recently trying to build coverage instrumentation for VS Code's extensions. This is pretty nasty since it seems like V8's coverage reports don't have any specific drive...