vscode exitStatus -> commandExitResult

fix https://github.com/microsoft/vscode/issues/167582 fyi @connor4312 to update the npm contrib

Dec 07 '22 02:12 meganrogge

When renaming or making API changes, it is probably good to also update the built-in extension; useful to test the change and also prevent the possibility of a broken release if one goes out between the time that a breaking change is merged and I have an opportunity to create, submit, and merge an additional PR.

Dec 07 '22 17:12 connor4312

@connor4312 I was also wondering if there are tests we could add that would fail if I were to forget to update the builtin extension?

Dec 07 '22 17:12 meganrogge

Does the .d.ts not get used? tsc would be able to ensure we don't break the extensions if so

Dec 07 '22 17:12 Tyriar

@Tyriar it does not because the command selector is a contribution

Dec 07 '22 17:12 meganrogge

The .d.ts does get used, but changes to contributions are not validated in that.

I was also wondering if there are tests we could add that would fail if I were to forget to update the builtin extension?

Hmm, we'd need to do some integration test type thing for that, since there isn't an API to check if a light bulb is shown in the UI

Dec 07 '22 17:12 connor4312