Mathieu Desnoyers

Results 14 comments of Mathieu Desnoyers
trafficstars

Indeed, we need to decide whether we want to reinstate this bt1 behavior into bt2 or not.

> To elaborate a bit, we use it to save blobs of memory that we can easily cast back to structured types. Why can't you use ctf_sequence or ctf_array for...

Those generated headers remove a few system calls, probably because your kernel was not compiled with "make allyesconfig" or similar. It also misses forward declarations so lttng-modules keeps building against...

kallsyms_symbol_value() was introduced in kernel v5­.0. Before that, module.c seems to access st_value field directly. We might want to introduce a wrapper in lttng-modules to use kallsyms_symbol_value for kernels 5.0+,...

Don't put extra time on this until we discuss the overall approach. Dumping 5MB worth of data in a statedump, mostly repeating information available from ELF and DWARF, seems inefficient....

The __rseq_table is indeed meant to be there for use by debuggers. We should document this as a user-space requirement, but I don't see why the kernel should mandate it....

I think we may want to consider allowing the ctf reader to deal with NULL enum entries without exception, and allow it to return NULL label "strings", and audit all...

I think someone suggested at some point to return "" rather than NULL when a label does not exist. But considering that "" is a valid string for an existing...

However, even if formatting a timestamp and a time range are two different things, it could all be exposed as a single option to the end user. Typical use will...

I'll use this opportunity to provide some feedback, some of which is based on our past experiments with lttng-scope. Here is a rather disorganized desiderata list: * When a non-time-x-axis...