Chris Martinez comments

Results 311 comments of


                                            Chris Martinez

trafficstars

Using versioning in conjunction with yarp reverse proxy

Just to clarify and make sure I understand, you have two app: 1. .NET Framework (4.x?) under `~/v2` 2. .NET 6.0 with API Versioning under `~/v3` Then you're using YARP...

Using versioning in conjunction with yarp reverse proxy

Gotcha. I think we are largely on the same page. API Versioning doesn't have any middleware. I'm not sure how it could be in front of YARP. I realize this...

Using versioning in conjunction with yarp reverse proxy

I'm not sure where the touch points are yet, but I did take a peek at some of the source. It looks like there is some involvement of ASP.NET Core...

Using versioning in conjunction with yarp reverse proxy

I've looked a little bit more at their code. I don't think the issue is necessarily precedence. Currently, there is a way to _advertise_ that an API version exists elsewhere,...

Using versioning in conjunction with yarp reverse proxy

Circling back around. I _think_ that the issue here was that YARP and the versioned APIs were in the same project. The reverse proxy should be its own project. API...

Workflow Permissions Should Be Least-Privileged

I completely spaced and forgot to include useful links to the documentation: - https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs - https://docs.github.com/en/actions/security-guides/automatic-token-authentication If I can get my head wrapped around everything that is required, I'll see...

Workflow Permissions Should Be Least-Privileged

I've reduced my workflows down to: ```yaml jobs: i-d-job: permissions: contents: write ``` Everything is still working. I didn't see anything that used the GitHub CLI or Pull Requests. There's...

Adding Odata in Versioning breaks the ability to perform select, filter etc. and Removing that breaks the swagger versioning

@akshaybheda Your configuration is **not** correct. Unfortunately, OData doesn't have extensibility points in its configuration so the required setup is split. The correct configuration would be: ```c# // add OData...

Adding Odata in Versioning breaks the ability to perform select, filter etc. and Removing that breaks the swagger versioning

@ElizabethOkerio Thanks for asking. I did talk to Sam about these issues circa Nov'20 before 8.0 was released. Here are a few of the most problematic areas: 1. [ODataOptions.RouteComponents](https://github.com/OData/AspNetCoreOData/blob/main/src/Microsoft.AspNetCore.OData/ODataOptions.cs#L74) as...

Adding Odata in Versioning breaks the ability to perform select, filter etc. and Removing that breaks the swagger versioning

@akshaybheda It looks like you might have deleted your post, but to answer your question: >The URL is /api/Orders/{key}/lineItems , I previously using ODataRoutePrefix in the controller and >[ODataRoute("({key})/lineItems")] was...