Chris Martinez

Results 307 comments of Chris Martinez
trafficstars

Some additional notes on this bug. - `EnableQueryAttribute.MaxTop` and `EnableQueryAttribute.MaxSkip` are incongruent - There is no global `SetMaxSkip` - Once enabled, `$skip` works without specifically setting `MaxSkip` - If `$top`...

Ok, I believe I've found the primary culprit. ## A Bit of _Astoria_ There is some historical context to `MaxTop` being `int` instead of `int?`. The main reason is that...

You need to also include the API Explorer extensions for API versioning for this to work. You would then add the configuration: ```c# config.AddVersionedApiExplorer(); ``` You can find a complete...

This will not work as defined. You **cannot** use a literal `v1`. When versioning by URL segment, you need to use the route constraint `v{version:apiVersion}`. It looks like you are...

The **ApiVersion** route parameter will already be ignored. Make sure you are using the API versioning API explorer extensions. It appears you are using ASP.NET Core, but this repo is...

@domaindrivendev, I don't fully know or understand the initialization steps that the CLI code path takes. Based on what @kepalas has demonstrated, things definitely went all the way through the...

Without walking through all of the code myself, it's hard to be sure. I spent some time looking at all the moving parts and it _looks_ right. A couple of...

@domaindrivendev excellent! My recommendation as a starting point would be to checkout the [Test Host](https://github.com/dotnet/aspnetcore/tree/master/src/Hosting/TestHost/src). You can probably use it in its entirety, but if not, it should provide a...

Just adding that you cannot explicitly request an upgrade either: ```http GET /order/123 HTTP/1.1 Host: api.company.com Connection: upgrade Upgrade: HTTP/2.0 ```

Strange... I guess I added the new function, but didn't refactor it or somehow forgot. It seems `TryResolvePolicy` still has the same logic, but after a closer inspection, I repro'd...