schema_salad

schema_salad copied to clipboard

Allowing type duplications is not documented in the spec

3

The spec of [Apache Avro](https://avro.apache.org/docs/1.11.1/specification/#unions) says: > Unions may not contain more than one schema with the same type, except for the named types record, fixed and enum. As [described...

tom-tan

See the nonsense coordinates produced at https://github.com/common-workflow-language/common-workflow-language.github.io/commit/0c84b7eaafd11b74429fd25e4c815657e7b35bdc#diff-8491d56fa84c7cab5a6bd3b018bdaf7ef72f4ed1e634ba7c63c467cbb7c27d78R108 [Reported by @tetron](https://matrix.to/#/!hqvfwcXAEIvyhYinQM:matrix.org/$ZFy_a8QOfeeeYYCGoYYIt9ZAaosrDUVQMfjtBKuSm9c)

mr-c

Counter-intuitive error message when parsing an empty file

1

If Schema SALAD `resolve_ref` method is used to parse an empty file, the returned error message is counter-intuitive.

GlassOfWhiskey

> 2023-01-05T23:13:49.598203507Z URI prefix '#bcftools_view.cwl/bcftools-view/min_count/min_count/min_count_type/min_count_type/' of '#bcftools_view.cwl/bcftools-view/min_count/min_count/min_count_type/min_count_type/:nref' not recognized, are you missing a $namespaces section? It is getting confused by the colon in the enum symbol name ":nref". The code...

tetron

Undocumented behavior in the case of unions of typeDSL-ed optional types

1

Here is a type definition of `SaladRecordField#jsonldPredicate`. https://github.com/common-workflow-language/schema_salad/blob/7662c7f16b1642bcc267ff8f9095c4c5220c329f/schema_salad/metaschema/metaschema.yml#L284-L287 According to the spec of SALAD, `string?` and `JsonldPredicate?` are expanded with the [typeDSL](https://www.commonwl.org/v1.2/SchemaSalad.html#Domain_Specific_Language_for_types) rule. It says: > If the type ends...

tom-tan

https://github.com/ionrock/cachecontrol/blob/master/docs/storage.rst#separatebodyfilecache See also https://github.com/ionrock/cachecontrol/issues/288

mr-c

By #480, the description of flattening rule in `$import` and its example are added. However, the [current spec](https://www.commonwl.org/v1.2/SchemaSalad.html#Import) does not describe this behavior. Is it accidentally reverted or is the...

tom-tan

Schema salad uses the ruamel.yaml "round trip" YAML parser. This parser preserves comments and line numbers by using `ruamel.yaml.comments.CommentedMap` `ruamel.yaml.comments.CommentedSeq`. These objects behave like Python maps/sequences, but have an additional...

tetron

Schema salad uses the ruamel.yaml "round trip" YAML parser. This parser preserves comments and line numbers by using `ruamel.yaml.comments.CommentedMap` `ruamel.yaml.comments.CommentedSeq`. These objects behave like Python maps/sequences, but have an additional...

tetron

https://github.com/psf/requests/issues/6240 Due to https://github.com/psf/requests/issues/6177 we are getting warnings by downstream users of schema-salad under Python 3.6; these warnings break tests in cwltest and probably other places

mr-c