Results 163 comments of Ivo List
trafficstars

Toolchainisation of protoc should make this possible.

This was most likely fixed by changes in proto_common not to add -I flag for each proto file transitively. Now the amount of flags passed to protoc is pretty small....

This is the change: https://github.com/bazelbuild/bazel/commit/699f3e8b61c217583436b99795341461587a3180

Also, we're already using params files for invoking protoc.

It's unclear what you're doing. The protobuf library looks nothing like the one on github: https://github.com/protocolbuffers/protobuf/blob/main/BUILD.bazel#L188

> How can I override the version provided out of the box? I don't immediately see any problem with your setup except: The order in the `WORKSPACE` file is important...

> @comius Continuing the discussion in [#510 (comment)](https://github.com/bazelbuild/bazel-skylib/pull/510#discussion_r1601250531) > > > It might be prone to more rebuilding (change one file and all the targets could be affected), but changes...

cc @brandjon Setting mnemonics from targets is something we had huge problems with internally.

This is an antipattern, because it's flattening a potentially large depset in order to search for a file. Skylib should not support such antipatterns or suggest people use them. What...