Ivo List
Ivo List
Ups, wrong button. > any thoughts? I am not sure what to make of the complete lack of feedback here. Too many reviewers - each one of them has time...
> @comius , any thoughts? I did a quick pass. Looks nice and looks ok, thanks. I'll do another more thorough pass and let you know.
Main problems: - release tgz contains rkt_1_{4-7}.tgz, legacy.tgz which additionally describe Kotlin/Java compiler flags - compiler repository depends back on rules_kotlin, to export .jars with `kt_jvm_import` rules (circular deps are...
I prepared PRs that fix this issue: - [ ] https://github.com/bazelbuild/rules_kotlin/pull/899 - [ ] https://github.com/bazelbuild/rules_kotlin/pull/900 - [x] https://github.com/bazelbuild/rules_kotlin/pull/901 - [x] https://github.com/bazelbuild/rules_kotlin/pull/896 and - [ ] https://github.com/bazelbuild/rules_kotlin/pull/902 First two PRs should...
> @comius I assume Walt is the right person to review this? Yes.
This doesn't look like proto rules issue.
Actually I'm working on this. What's missing is rules_kotlin.
I added more info on what needs to happen on rules_kotlin in https://github.com/bazelbuild/rules_kotlin/issues/660 > Do we also have someone from the protobuf team looking into supporting Bzlmod? Not anybody in...
cc @alexeagle @thesayyn, please triage/fix
Thanks @alexeagle for your suggestions :) The issue has been fixed in protobuf repo.