Ivo List
Ivo List
Update: Not stuck, I'm still fixing internal tests.
After importing the PR, I realised the blast radius of the denormalization of build.proto (having information on target instead on rule class) is much bigger that what I previously thought,...
I missed that this PR is waiting for me. Is there still interest to get it in? This is exposing Action.env_inherit, which is only accessible to tests, right? And that's...
@lberki Is this ready for a review? Does it need 3 reviewers? Can you import it? I find internal reviews more pleasant than GitHub.
hey @lberki, do you perhaps know if this ordering/overwriting was intentional or accidental? With this PR, there might be a risk that a Starlark rule overwrites PATH variable or some...
> Doing some code archaeology (I went back as far as cl/146237448), it looks like this ordering was what Blaze did before it was Bazel and no one wanted to...
The code was approved by @trybka internally, suggesting to change the name from cpp20_modules to cpp_modules in the code, except in the documentation/some comments. I applied the changes, to move...
>> Because Bazel cannot properly handle source files with spaces in the path, linking will fail, so I won't address this issue for now. > @comius is this a BUG...
> Subsequently when packaging things into RPMs we are generating Bar-devel RPM that contains only headers. In my understanding of how providers work, we're not going to be able to...
>> Setting mnemonics from targets is something we had huge problems with internally. > Does this impact the inclusion of this change or can you restrict the use of the...