Make env on test rules override --test_env

[keith]

trafficstars

Fixes https://github.com/bazelbuild/bazel/issues/14418

[comius]

hey @lberki, do you perhaps know if this ordering/overwriting was intentional or accidental?

With this PR, there might be a risk that a Starlark rule overwrites PATH variable or some other important variables. (or it might be a feature). Or I might be overthinking it.

[lberki]

Doing some code archaeology (I went back as far as cl/146237448), it looks like this ordering was what Blaze did before it was Bazel and no one wanted to change the semantics for fear of breaking some legacy behavior.

[comius]

Doing some code archaeology (I went back as far as cl/146237448), it looks like this ordering was what Blaze did before it was Bazel and no one wanted to change the semantics for fear of breaking some legacy behavior.

Ok. So let's see if that's still there.

[keith]

@bazel-io flag

[iancha1992]

@bazel-io fork 7.2.0