Colin Rogers

Results 41 comments of Colin Rogers

I agree that we don't want "sub" DAGs but the idea that a single DAG is safe/scaleable to enterprise orgs doesn't make sense. We could imagine a scenario where we...

> I like the idea of trying to also incorporate the changes I recommended in https://github.com/dbt-labs/dbt-core/issues/5521#issuecomment-1246795511, which would enable the full removal of dbt_utils.current_timestamp by dbt-utils v1.0. Will pull those...

> Could you implement a test that confirms that `current_timestamp_in_utc` yields the expected _value_ as well as the expected data type? I'd suggest something like [this](https://github.com/dbt-labs/dbt-core/pull/5935/files#diff-2ac0a701cbb34cffba92f797869e76e9ef01913841d006d074eb0248c2794268R39-R46). While we certainly could...

Received offline feedback concerning the need to include a "backcompat" macro for `current_timestamp_in_utc` as we may be diverging from dbt-utils versions in a breaking manner. Digging in there are two...

> One easy way to test the backwards compatibility is just to compare the new SQL to the old SQL. If they are the same, then we are done. Good...

Here is where I ended up at for dbt-core changes: https://github.com/dbt-labs/dbt-core/pull/5838/files#diff-4ce397ee2492fb1078425ea420483cf3b55645b5bbcee3139ae696ad07c6c1bc Still need to polish/test everything but it consolidates the dbt-core logic into a single file. Can reconcile our two...

Mind adding another functional test? Should be able to just copy `TestAccessGrantSucceeds` -> `TestAccessGrantSucceedsWithFullRefresh` and add some validation the expected grants are/not present: https://github.com/dbt-labs/dbt-bigquery/blob/main/tests/functional/adapter/test_grant_access_to.py#L80

Thanks for surfacing, approximately how many times have you observed this behavior?

Also, can you share the complete model `config`? I can't reproduce locally and haven't heard this from other users, without more info I don't think there's much more we can...

@maksym-dibrov-solidgate (on slack): _tried with 1.4.9 - still the same issue. Table materialization style is "table" and I get OID does not exist errors when trying to read it during...