smiley

Results 26 comments of smiley

...which reminds me that i already did this https://github.com/php-fig/http-message/compare/master...codemasher:type-hints-php7.1 ~~Might aswell submit a PR?~~ v2.0 => PHP 7.0, v2.1 => PHP 7.1 (void & iterable)

There you go: https://github.com/php-fig/http-message/compare/master...codemasher:type-hints-php7.1 I've also changed the `array` type parameters of `ServerRequestInterface::withCookieParams()` and `ServerRequestInterface::withUploadedFiles()` to `iterable` to allow more flexibility.

In addition to a PHP 7 upgrade, i'd like to propose to allow chaining of `StreamInterface::seek()` and `StreamInterface::rewind()` (https://github.com/codemasher/http-message/commit/05c9c0bd399029a4ab8f81c35dbc49b70938ca0f) `$message->getBody()->rewind()->getContents();`

> Hi @GrahamCampbell ! 2 years yet have passed, so when we can get a typed version? =) An entire majpr PHP version has passed! Sorry, but at this point...

Hi, just a heads-up: base64 output for SVG exists only from [v3.4 onwards (v4.x backport)](https://github.com/chillerlan/php-qrcode/issues/67), so the best bet in this case is to always disable base64 and let `Google2FA`...

Hey, this is basically how it was/is implemented in v5 and earlier but it comes with several downsides such as testing issues and flexibility when extending - also `match()` is...

@seebeen To be honest, I dislike most of the GD stuff and if it were up to me I'd remove it entirely in favor of ImageMagick and SVG haha. It...

I should add: - the `$outputType` option and its associated constants in `QROutputInterface` shall be gone - the output class is invoked and identified by its FQCN only - a...

Hmm, i know this library but I don't see how it could solve my particular issue here and i don't want to add more layers of abstraction or more complicated...

Semi-related: added basic `intervention/image` support in https://github.com/chillerlan/php-qrcode/commit/b231433d56512eb1fd31895e14e4f8c7c6a459fe