Jacob Zhong

Results 117 comments of Jacob Zhong

> @cmpute Ah, I see. I actually thought it was going to be a part of the `num` family because of it's name; `num-irrational` really sounds like it belongs there....

It seems that the remaining errors are due to dynamic array allocating. I don't know whether it's legal in other compilers, but `int pcm_data[some_variable]` is not legal in MSVC. This...

Thanks for the proposal! I'm not sure if this change results in a performance change, I will merge it after I have a better benchmark implementation, and confirmed that this...

This is the change (compared to the master branch) measured on my PC: Criterion logs ``` ubig_add/10 time: [2.3766 ns 2.3826 ns 2.3928 ns] change: [-1.7571% -0.9668% -0.3367%] (p =...

It seems that the benchmark needs improving... I will try this PR before the next major version release, when I will compare again the performance of `dashu` against other libraries.

wow, thanks for putting effort into this so quickly! Glad to see this!

I'm open for the merge timepoint :) Waiting for 0.22 sounds good to me!

I have rebased the code, not sure why the codecov check failed tho.

Agree!. And if more changes are allowed, I propose to further change the type of start/stop/length of `PySliceIndices` all to `usize`, and impleming using the recommended new APIs `PySlice_Unpack` and...

> I'm certainly open to making those changes to fit better with what Python offers, but we should consider the compatibility story. There's a lot changing in 0.21 already and...