Chris Kushnir

Results 11 comments of Chris Kushnir

I would vote for 1. I'd suggest building both libmbin.dll and mbincompiler.exe to target .NET 6. I probably wouldn't create a libmbin-net5.dll unless it was proven necessary - upgrading a...

For what it's worth the nmsmb outputs (dll and exe) both target .NET 6 and are able to load libmbin.dll .NET 5 as both a dep ref and explicitly w/o...

I would still vote to upgrade both libmbin.dll and mbincompiler.exe to .NET 6. If you are concerned w/ issues then add as new build assets and give them the -net6...

If no tools _need_ to be .NET 5 then might be easier to just drop 5 support and call 6 libmbin and mbincompiler i.e. drop version from name.

- ExoticExtra1 - 6: Those are the values in one of the enum's the code defines. False positive. - MBINCompiler.dll and AppHost.pdb - It's a .NET app. .NET uses a...

The report said that v.beahh.com was discovered in the network traffic, but I didn't think MBINCompiler.exe did any network calls, so not sure where that would come from.

When I look at the details of those reports, with the understanding of what the code does and how the assets are built, to me it seems like they don't...

I'd just stick to your first point - "formalise the concept of a "pre-release" by only ever making these a "pre-release" in the strict term of github releases" and stop...

Hmm, not familiar w/ CI requirements|limits. If you need a naming convention to identify if the release should be flagged as a pre-release or not then I guess that kinda'...

Hmm, personally i probably would have had accountdata_mapping.json for accountdata.hg, and save_mapping.json for save*.hg. Although pc gog and steam seem to use a similar format for both accountdata.hg and save*.hg...