Chris

Results 13 comments of Chris

Managed to get this working on the CI pipeline referenced above by adding `.WithHostname("localhost")` (this is TestContainers.Net using the image). I was seeing a strange ORA-12514 error message Service XEPDB1...

@mitchdenny or @danmoseley are you able to take a look at this?

> Importing the Otel package to internal feed so we can build this. @mitchdenny or @eerhardt are you able to add Testcontainers.Oracle to the internal feed as well to get...

@eerhardt @sebastienros would you be able to take a look with the failing tests? I've got them working on my machine, and made some progress on working out what's needed...

I went through the different non-default settings of the OracleDataProviderInstrumentationOptions, and setting `EnableConnectionLevelAttributes = true` does provide: ![image](https://github.com/dotnet/aspire/assets/54735/f6c95361-cb1a-4046-b7f2-8cbfb1e8ea75) That results in the addition of db.name, db.user, server.address and server.port being...

> Looking at the test results the first test fails with: > > Oracle might be taking a longer time to start up, or failing at some point? I would...

> > That results in the addition of db.name, db.user, server.address and server.port being set on the spans. > > `db.name` and `db.user` aren't standard parameters. Making them opt-in makes...

@eerhardt looks to be, from the playground with that property turned on results in this for the sendExecuteRequest span: ![image](https://github.com/dotnet/aspire/assets/54735/7e99d259-d330-4983-b788-d81eed2b117f) ![image](https://github.com/dotnet/aspire/assets/54735/d5df0dcb-b2ea-4f48-a66b-8292f7eab0a1) I'll make that the default for now, with a...

@mitchdenny and @eerhardt anything more you want doing on this?

@eerhardt given the clarification above do you have a steer on what needs doing to get this merged? 1. Back to the default `EnableConnectionLevelAttributes` - for now devs will have...