ClAndrew

Results 12 comments of ClAndrew
trafficstars

Thanks for doing this! Overall looks good, but I'll take a closer look this weekend when I'm on my dev computer.

I did a quick test of this change locally and it looks good! Thank you @derekgates :) None of my comments are blocking. The only thing that seems a bit...

That's a tough one. How I would fix it personally is do a branch reset back to where the branch was created off of the remote, then create 1 or...

Hey, coming back to this- I'm still interested in taking this PR- if it's alright with you, I was going to try and merge it this evening. Yeah, as a...

I'm trying to think, what would be easier? A hotkey?

Hiding the RPC when Winamp is paused is definitely doable. Actually come to think of it, someone had a PR to do just that but they ran into Git problems...

This sounds pretty reasonable. There is a clean enough factoring of the "unhook me from Discord" code. Hopefully I can get around to it one of these days :)

Maybe. See this example https://github.com/Tustin/PlayStationDiscord/blob/development/src/Consoles/PlayStation3.ts

I think addressing this issue will be 90% investigation and 10% coding the thing

Thanks for reporting this. I wonder what's changed between that version and the tested ones. I'm swamped with my day job work right now so it might be a ways...