Chris Krycho

Results 769 comments of Chris Krycho

Ugh, sorry. Fell off my radar and the other two maintainers have had COVID. I’ll look at it again on Monday.

@charlesfries if you have bandwidth to help push on the TS story for Ember Data, I am going to have a task written up at the end of the week...

No problem, and thanks for the nudge!

👋🏼 In Ember.js' testing against TS, we noted failures against 4.9 starting with the `4.9.0-dev.20221014` release. I believe these are legitimate issues (the fix [here](https://github.com/emberjs/ember.js/pull/20227) is demonstrably *all sorts* of...

Sorry, forgot about this in the midst of a bunch of other things—just kicked back off CI for it and will take another review pass later today!

Yeah, I noted that and will bring it up with folks next week! Thanks for checking in. Just had end-of-quarter extra stuff these past couple weeks.

Heyoooo, adding tests for `typescript@next` *already caught an issue*! 🎉 I’ll get this fixed in a backwards-compatible way tomorrow and update.

This is, I think, the same as #18860—the problem is that our native class support *does not* support "zebra-striping" this way, i.e. switching between classic, native, and classic again classes...

@geneukum good call. Let me add that to the list of tasks – and also, a colleague mentioned to me late Friday that he’s also interested in helping; let's coordinate...