ember.js
ember.js copied to clipboard
emberjs
Create public import for `uniqueId` helper
Adds public import for uniq-id
https://github.com/emberjs/ember.js/issues/20165
Sorry, forgot about this in the midst of a bunch of other things—just kicked back off CI for it and will take another review pass later today!
Sorry, forgot about this in the midst of a bunch of other things—just kicked back off CI for it and will take another review pass later today!
Hey @chriskrycho , pls let me know how we should proceed here. As it stands, I dont think we could just use invokeHelper per my comment on the suggestion. Happy to dig further!
Yeah, I noted that and will bring it up with folks next week! Thanks for checking in. Just had end-of-quarter extra stuff these past couple weeks.
I met with @TechieQian and we discussed the bulk of the open issues here.
I took some (very incomplete and possibly cryptic) notes during the meeting: https://gist.github.com/wycats/6800716eb6744f63d9b9396670d5c625
The next steps are to meet about this in a spec meeting. @TechieQian is available to attend whenever the discussion is on the agenda. It's a pretty meaty topic, so we'll want to allocate plenty of time to discuss it.
One observation that we made: since "functions as helpers" is now the law of the land, it basically works to export the uniqueId JS function and have people use it in <template>.
However, we'd need to be sure that we guarantee that when a function with no autotracking dependencies is used as a helper, it's never spuriously re-evaluated. I believe that this is the case today, but we'd need to be really sure.
- This needs a rebase.
- Last time we were here, CI was failing, and there were open questions about how to get it the rest of the way across the line. It was not clear to me from @wycats' comment above whether it's actually unblocked here or not.
Will happily rebase and continue when 2. Is resolved.
On Wed, Feb 15, 2023 at 12:59 PM Chris Krycho @.***> wrote:
- This needs a rebase.
- Last time we were here, CI was failing, and there were open questions about how to get it the rest of the way across the line. It was not clear to me from @wycats https://github.com/wycats' comment above whether it's actually unblocked here or not.
— Reply to this email directly, view it on GitHub https://github.com/emberjs/ember.js/pull/20171#issuecomment-1431783678, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADQ4LZAOTAF2SOMFIJZLSULWXUKR3ANCNFSM576MSXVA . You are receiving this because you were mentioned.Message ID: @.***>
I believe that this is the case today, but we'd need to be really sure.
I have never observed behavior to the contrary -- functions with no consumed tracked data never re-evaluate (unless the parent context is torn down and re-rendered -- which would be expected, ofc)
Can we move forward with this PR? <3
I pushed up a rebase + some minor tweaks in #20464 -- thanks for getting this started @TechieQian !!! you're the best :tada:
